Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #168
Part of #181
This change gets rid of the
Marker
object that we were using to mark where the cursor was before a jump to the toolbox or flyout.That
Marker
was a variant on aCursor
, and there was no way to hide it once it had been shown.In November and January we decided that the marker workflow was confusing, and that the marker should only be visible while actively inserting a block from the toolbox/flyout. In this context, the marker shows where the selected block will be inserted. The marker is then expected to disappear after the block is inserted.
Before this change, the marker stuck around after the new block was inserted. Calling
hide
on the marker didn't make it go away, because core Blockly redrew it during the next render pass.Changes in this PR
navigation.ts
.PassiveFocus
, that renders passive focus at a specific location. This new class only keeps track of it location to let it hide later.