Addressing PR review comments.

google · Sep 20, 2024 · 3c9568a · 3c9568a
1 parent aa5ccf1
commit 3c9568a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 17 deletions.
diff --git a/blocks/lists.ts b/blocks/lists.ts
@@ -417,10 +417,7 @@ const LISTS_GETINDEX = {
       options: this.WHERE_OPTIONS,
     }) as FieldDropdown;
     menu.setValidator(
-      /**
-       * @param value The input value.
-       * @returns Null if the field has been replaced; otherwise undefined.
-       */
+      /** @param value The input value. */
       function (this: FieldDropdown, value: string) {
         const oldValue: string | null = this.getValue();
         const oldAt = oldValue === 'FROM_START' || oldValue === 'FROM_END';
@@ -645,10 +642,7 @@ const LISTS_SETINDEX = {
       options: this.WHERE_OPTIONS,
     }) as FieldDropdown;
     menu.setValidator(
-      /**
-       * @param value The input value.
-       * @returns Null if the field has been replaced; otherwise undefined.
-       */
+      /** @param value The input value. */
       function (this: FieldDropdown, value: string) {
         const oldValue: string | null = this.getValue();
         const oldAt = oldValue === 'FROM_START' || oldValue === 'FROM_END';
@@ -816,11 +810,8 @@ const LISTS_GETSUBLIST = {
           this[('WHERE_OPTIONS_' + n) as 'WHERE_OPTIONS_1' | 'WHERE_OPTIONS_2'],
       }) as FieldDropdown;
       menu.setValidator(
-        /**
-         * @param value The input value.
-         * @returns Null if the field has been replaced; otherwise undefined.
-         */
-        function (this: FieldDropdown, value: string) {
+      /** @param value The input value. */
+      function (this: FieldDropdown, value: string) {
           const oldValue: string | null = this.getValue();
           const oldAt = oldValue === 'FROM_START' || oldValue === 'FROM_END';
           const newAt = value === 'FROM_START' || value === 'FROM_END';

diff --git a/blocks/text.ts b/blocks/text.ts
@@ -223,10 +223,7 @@ const GET_SUBSTRING_BLOCK = {
           this[('WHERE_OPTIONS_' + n) as 'WHERE_OPTIONS_1' | 'WHERE_OPTIONS_2'],
       }) as FieldDropdown;
       menu.setValidator(
-        /**
-         * @param value The input value.
-         * @returns Null if the field has been replaced; otherwise undefined.
-         */
+        /** @param value The input value. */
         function (this: FieldDropdown, value: any): null | undefined {
           const oldValue: string | null = this.getValue();
           const oldAt = oldValue === 'FROM_START' || oldValue === 'FROM_END';