Skip to content

Commit

Permalink
fix: workspace shifts when deleting a block (#8666)
Browse files Browse the repository at this point in the history
* fix: workspace shifts when deleting a block

* fix: awaiting for block rerender

* fix: create reusable method to prevent marking method as async
  • Loading branch information
mateusslezinsky authored Dec 4, 2024
1 parent eb79f66 commit 7219800
Showing 1 changed file with 10 additions and 5 deletions.
15 changes: 10 additions & 5 deletions core/dragging/block_drag_strategy.ts
Original file line number Diff line number Diff line change
Expand Up @@ -384,19 +384,24 @@ export class BlockDragStrategy implements IDragStrategy {
if (this.connectionCandidate) {
// Applying connections also rerenders the relevant blocks.
this.applyConnections(this.connectionCandidate);
this.disposeStep();
} else {
this.block.queueRender();
this.block.queueRender().then(() => this.disposeStep());
}

if (!this.inGroup) {
eventUtils.setGroup(false);
}
}

/** Disposes of any state at the end of the drag. */
private disposeStep() {
this.block.snapToGrid();

// Must dispose after connections are applied to not break the dynamic
// connections plugin. See #7859
this.connectionPreviewer!.dispose();
this.workspace.setResizesEnabled(true);

if (!this.inGroup) {
eventUtils.setGroup(false);
}
}

/** Connects the given candidate connections. */
Expand Down

0 comments on commit 7219800

Please sign in to comment.