refactor: Make dropdown field image metrics static.

google · Nov 4, 2024 · c330f5c · c330f5c
1 parent 2373d89
commit c330f5c
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/core/field_dropdown.ts b/core/field_dropdown.ts
@@ -99,10 +99,10 @@ export class FieldDropdown extends Field<string> {
    * The y offset from the top of the field to the top of the image, if an image
    * is selected.
    */
-  protected IMAGE_Y_OFFSET = 5;
+  protected static IMAGE_Y_OFFSET = 5;
 
   /** The total vertical padding above and below an image. */
-  protected IMAGE_Y_PADDING = this.IMAGE_Y_OFFSET * 2;
+  protected static IMAGE_Y_PADDING = FieldDropdown.IMAGE_Y_OFFSET * 2;
 
   /**
    * @param menuGenerator A non-empty array of options for a dropdown list, or a
@@ -529,7 +529,7 @@ export class FieldDropdown extends Field<string> {
     const hasBorder = !!this.borderRect_;
     const height = Math.max(
       hasBorder ? this.getConstants()!.FIELD_DROPDOWN_BORDER_RECT_HEIGHT : 0,
-      imageHeight + this.IMAGE_Y_PADDING,
+      imageHeight + FieldDropdown.IMAGE_Y_PADDING,
     );
     const xPadding = hasBorder
       ? this.getConstants()!.FIELD_BORDER_RECT_X_PADDING