feature: Replace text quotes and pilcrow with custom font #5868
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changing from bitmaps to vectors significantly improves the visual quality of these blocks. Also reduces the code size. Once we have a custom font, this will allow other assets such as the dropdown arrow, the menu checkmark, the toolbox category arrows, and maybe more.
FieldImage used to be used for the bitmaps.
|
Converting to a draft PR. This change has exposed deeper pre-existing issues with text-length measurement. Unsure how to fix. |
|
Can we do a fixed-size vector image instead of a font? It would still scale better and wouldn't need to be measured. |
However, this exposes a more serious issue with Blockly which needs to be adressed first. `getFastTextWidth` fails to honour CSS directives in the label's class.
|
@rachel-fenichel Let's address #5871 first, then reevaluate our position here. |
|
I'm gonna go ahead and close this since it might be a few months before we get back around to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changing from bitmaps to vectors significantly improves the visual quality of these blocks. Also reduces the code size.
Once we have a custom font, this will allow other assets such as the dropdown arrow, the menu checkmark, the toolbox category arrows, and maybe more.
Old UI:
New UI: