feat: add connection previewer interface #7637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
PR: feature
maribethb
approved these changes
Nov 9, 2023
| * is being replaced. | ||
| */ | ||
| previewReplacement( | ||
| draggedCon: RenderedConnection, |
There was a problem hiding this comment.
nit (and you can disagree with me here) but I prefer "conn" as the abbreviation for "connection" if we're going to abbreviate it at all. apologies as i meant to leave this comment in your doc but hoping i've caught you early enough here
There was a problem hiding this comment.
Oh yeah totally good! I did the types in a separate PR partially so that it would be easier to bike shed :P So this is perf!
BeksOmega
added a commit
to BeksOmega/blockly
that referenced
this pull request
Feb 2, 2024
* feat: add connection previewer interface * chore: PR comments
BeksOmega
added a commit
that referenced
this pull request
Feb 2, 2024
* feat: add connection previewer interface * chore: PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The basics
The details
Resolves
Work on #7204
Proposed Changes
Adds an
IConnectionPreviewerinterface for later use.Reason for Changes
Working on making it possible to swap out the connection preview method.
Test Coverage
No tests yet because this just defines a type not behavior.
Documentation
N/A
Additional Information
Merging this into a feature branch b/c I'm not sure if I'll be able to get it done in time for the release or not.