Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deps)!: Bump JSDOM to v23, dropping node 16. #7729

Merged
merged 2 commits into from
Jan 8, 2024
Merged

chore(deps)!: Bump JSDOM to v23, dropping node 16. #7729

merged 2 commits into from
Jan 8, 2024

Conversation

BeksOmega
Copy link
Collaborator

@BeksOmega BeksOmega commented Dec 19, 2023 •
edited
Loading

Rerolls #7667 to bump JSDOM which bumps our min version of node.

Breaking changes

Drops support for Node v16.

@BeksOmega BeksOmega added the breaking change Used to mark a PR or issue that changes our public APIs. label Dec 19, 2023
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. labels Dec 19, 2023
@BeksOmega BeksOmega force-pushed the revert-7694-revert-7667-dependabot/npm_and_yarn/develop/jsdom-23.0.0 branch from 9033eb6 to 07f1066 Compare December 19, 2023 19:13
@BeksOmega BeksOmega marked this pull request as ready for review December 19, 2023 19:16
@BeksOmega BeksOmega requested a review from a team as a code owner December 19, 2023 19:16
@BeksOmega BeksOmega requested review from cpcallen and removed request for a team December 19, 2023 19:16
@BeksOmega BeksOmega marked this pull request as draft December 19, 2023 19:16
cpcallen
cpcallen approved these changes Dec 21, 2023
View reviewed changes
Copy link
Contributor

@cpcallen cpcallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I wonder if we should start providing an engines clause in package.json.

@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jan 2, 2024
@BeksOmega
Copy link
Collaborator Author

LGTM, but I wonder if we should start providing an engines clause in package.json.

Seems reasonable! Done.

@BeksOmega BeksOmega changed the base branch from rc/v11.0.0 to v11-breaks January 8, 2024 21:53
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jan 8, 2024
@BeksOmega BeksOmega marked this pull request as ready for review January 8, 2024 21:53
@BeksOmega BeksOmega merged commit d5704b7 into v11-breaks Jan 8, 2024
11 checks passed
@cpcallen cpcallen changed the title chore(dependency)!: Bump JSDOM to v23, dropping node 16. chore(deps)!: Bump JSDOM to v23, dropping node 16. Jan 16, 2024
@github-actions github-actions bot added breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) and removed breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc) labels Jan 16, 2024
@cpcallen cpcallen mentioned this pull request Jan 16, 2024
Closed
BeksOmega added a commit that referenced this pull request Jan 23, 2024
@BeksOmega
chore(dependency)!: Bump JSDOM to v23, dropping node 16. (#7729)
7ef47d1 
* Revert "Revert "chore(deps): Bump jsdom from 22.1.0 to 23.0.0 (#7667)" (#7694)"

This reverts commit f0c3f33.

* chore: add engine
@cpcallen cpcallen mentioned this pull request Mar 8, 2024
Closed
@BeksOmega BeksOmega mentioned this pull request Jul 8, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpcallen cpcallen cpcallen approved these changes

Assignees

@cpcallen cpcallen

Labels
breaking change Used to mark a PR or issue that changes our public APIs. PR: chore General chores (dependencies, typos, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BeksOmega @cpcallen