refactor!: replaced None with nil in lua-generator #7731
Conversation
BeksOmega
changed the title
github-actions
bot
added
breaking change
|
@neerajkumarc since this is a breaking change, we're going to hold this for a bit so we can release non-breaking changes in mid Februrary. So I'm going to convert this to a draft to make sure it doesn't get merged accidentally! But it has been approved and will go in once we're set up to accept it =) |
* test(generators): Add generator TS import/use tests * fix(generators): Fix generator type declarations Add a missing ./ prefix to the imports in the generator wrapper .d.ts files. Fixes: google#7741
* Revert "Revert "chore(deps): Bump jsdom from 22.1.0 to 23.0.0 (google#7667)" (google#7694)" This reverts commit f0c3f33. * chore: add engine
|
Heya @neerajkumarc Would you have time to rebase this against the |
neerajkumarc
force-pushed
the
fix/lua-generator
branch
from
252b068 to
d5704b7
Compare
|
I tried rebasing it, but somehow, I messed up my local Git repo and pushed some weird commits. I rolled back those changes and want to apologize for any inconvenience caused.🙏 |
|
It's all good! Git is really tricky. But it looks like you might have actually dropped your original changes :/ If you're still interested inworking on this, the easiest thing to do is probably to branch from |
|
@neerajkumarc Are you still interested in working on this? If not I'll close it next Friday! |
|
@neerajkumarc I'm going to go ahead and close this! Thank you for your work on it =) |
Fixes #6720
The basics
The details
Resolves
Fixes
Proposed Changes
Reason for Changes
Test Coverage
Documentation
Additional Information