Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent console logging duplicate deprecation warnings #7733

Merged
merged 9 commits into from
Jan 9, 2024
Merged

fix: prevent console logging duplicate deprecation warnings #7733

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c9a36d2
(feat): added Set to prevent console logging multiple deprecation war…
ebrahim95 Dec 19, 2023
5aa0497
feat!: added Set to prevent console logging multiple deprecation warn…
ebrahim95 Dec 19, 2023
26422bd
Merge branch 'dev_changes' of https://github.com/ebrahim95/blockly in…
ebrahim95 Dec 20, 2023
466c00d
refactor: renamed variable and rewrote comment
ebrahim95 Dec 21, 2023
4837ea1
refactor: added guard clause and rewrote comment
ebrahim95 Dec 21, 2023
21f9017
refactor: removed checkMsg Variable name and replaced it with previou…
ebrahim95 Jan 5, 2024
ed1ccc2
refactor: removed checkMsg Variable name and replaced it with previou…
ebrahim95 Jan 5, 2024
7d9745e
Merge branch 'dev_changes' of github.com:ebrahim95/blockly into dev_c…
ebrahim95 Jan 5, 2024
10430e1
Merge branch 'google:develop' into dev_changes
ebrahim95 Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions core/utils/deprecation.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,9 @@

// Former goog.module ID: Blockly.utils.deprecation

// Set of previously-emitted warnings.
const previousWarnings = new Set();

/**
* Warn developers that a function or property is deprecated.
*
Expand Down Expand Up @@ -33,5 +36,12 @@ export function warn(
if (opt_use) {
msg += '\nUse ' + opt_use + ' instead.';
}

// Don't log deprecation warnings multiple times.
if (previousWarnings.has(msg)) {
return;
}

previousWarnings.add(msg);
console.warn(msg);
}
Loading