fix: Don't create intermediate variables when renaming a procedure argument.

[gonfunko]

The basics

• I validated my changes

The details

Resolves

Fixes #8693

Proposed Changes

This PR updates the procedure argument renaming logic to rename the variable being edited, rather than creating a new one for every keystroke and cleaning up the intermediate states when the field editor is dismissed. This prevents intermediate variables from appearing in the flyout when it is open while a procedure argument's name is being edited in the mutator.

[rachel-fenichel]

Christopher said to also check one edge case: "When checking any fix for this, do test (or better still: add tests) to see what happens if one of the intermediate variable names clashes with another variable/parameter—e.g., if there is a variable foo and you rename a parameter from f to food."

Did you check it, and does it work?

[gonfunko]

Yes and yes; behavior appears identical to the old version in that case. The pre-existing variable does not get deleted if you temporarily land on it but continue past it, and if you name the arg the same they coalesce.

[rachel-fenichel]

This looks good to me--I like that you are actually using the variable object to make sure that you can just change the active variable, instead of creating a pile of them and then going back to delete.

We have several versions of the procedure blocks now--particularly in block-plus-minus and block-shareable-procedures. Please check whether you can apply the same fix there, and either apply it or file bugs to track that work.