Skip to content

Commit

Permalink
Merge pull request #322 from vmarmol/cleanup
Browse files Browse the repository at this point in the history
Misc cleanups
  • Loading branch information
rjnagal committed Nov 20, 2014
2 parents 6885e0c + f185c60 commit fe245a7
Show file tree
Hide file tree
Showing 4 changed files with 1 addition and 60 deletions.
15 changes: 0 additions & 15 deletions CONTRIBUTORS

This file was deleted.

34 changes: 0 additions & 34 deletions info/advice.go

This file was deleted.

5 changes: 0 additions & 5 deletions manager/container.go
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,6 @@ var HousekeepingInterval = flag.Duration("housekeeping_interval", 1*time.Second,
var maxHousekeepingInterval = flag.Duration("max_housekeeping_interval", 60*time.Second, "Largest interval to allow between container housekeepings")
var allowDynamicHousekeeping = flag.Bool("allow_dynamic_housekeeping", true, "Whether to allow the housekeeping interval to be dynamic")

// Internal mirror of the external data structure.
type containerStat struct {
Timestamp time.Time
Data *info.ContainerStats
}
type containerInfo struct {
info.ContainerReference
Subcontainers []info.ContainerReference
Expand Down
7 changes: 1 addition & 6 deletions manager/manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

// TODO(cAdvisor): Package comment.
// Manager of cAdvisor-monitored containers.
package manager

import (
Expand Down Expand Up @@ -501,11 +501,6 @@ func (m *manager) detectSubcontainers(containerName string) error {
return nil
}

func (self *manager) processEvent(event container.SubcontainerEvent) error {
// TODO(cAdvisor): Why does this method always return nil? [satnam6502]
return nil
}

// Watches for new containers started in the system. Runs forever unless there is a setup error.
func (self *manager) watchForNewContainers(quit chan error) error {
var root *containerData
Expand Down

0 comments on commit fe245a7

Please sign in to comment.