-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: support multi nodes config for es #3568
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Hi @hyphennn. Thanks for your PR. I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
300391a
to
aad94de
Compare
aad94de
to
453d189
Compare
/ok-to-test |
/ok-to-test |
I forked this repo with my PR, then run it in my company's project. Until now, after more than one month, I think it works well. Looking forward to this PR being accepted. |
/ok-to-test |
I do appreciate your work, @hyphennn, but for some reason I can't trigger missing CI build step :| |
Haha, never mind. Maybe we need wait for sometime |
/ok-to-test |
This PR is mainly commited to support the issue #3567 , which allow users to configure multi nodes for elasticsearch.