Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: support multi nodes config for es #3568

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hyphennn
Copy link

This PR is mainly commited to support the issue #3567 , which allow users to configure multi nodes for elasticsearch.

Copy link

google-cla bot commented Jul 17, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@k8s-ci-robot
Copy link
Collaborator

Hi @hyphennn. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@iwankgb
Copy link
Collaborator

iwankgb commented Sep 7, 2024

/ok-to-test

@iwankgb iwankgb closed this Sep 7, 2024
@iwankgb iwankgb reopened this Sep 7, 2024
@iwankgb
Copy link
Collaborator

iwankgb commented Sep 7, 2024

/ok-to-test

@hyphennn
Copy link
Author

I forked this repo with my PR, then run it in my company's project. Until now, after more than one month, I think it works well. Looking forward to this PR being accepted.

@iwankgb
Copy link
Collaborator

iwankgb commented Sep 10, 2024

/ok-to-test

@iwankgb
Copy link
Collaborator

iwankgb commented Sep 10, 2024

I do appreciate your work, @hyphennn, but for some reason I can't trigger missing CI build step :|

@hyphennn
Copy link
Author

I do appreciate your work, @hyphennn, but for some reason I can't trigger missing CI build step :|

Haha, never mind. Maybe we need wait for sometime

@iwankgb
Copy link
Collaborator

iwankgb commented Oct 4, 2024

/ok-to-test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants