Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace commonLabels with labels #3603

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

JoeyC-Dev
Copy link

Proposed change:
Replaced the deprecated commonLabels with labels

Supporting point:
Currently, if executing the following command, the error will pop:

VERSION=v0.49.1
kustomize build "https://github.com/google/cadvisor/deploy/kubernetes/base?ref=${VERSION}" | kubectl apply -f -
# Warning: 'commonLabels' is deprecated. Please use 'labels' instead. Run 'kustomize edit fix' to update your Kustomization automatically.

Justification of the change:
In my consideration, both includeSelectors and includeTemplates are not needed. It does work without using them. But the behaviour of commonLabels (referring to old method) will use includeSelectors and includeTemplates mandatory, while these are not necessary at all.
If the team believes includeSelectors and includeTemplates are needed, please comment so and I will add them.

Copy link

google-cla bot commented Oct 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant