Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change:
Replaced the deprecated
commonLabels
withlabels
Supporting point:
Currently, if executing the following command, the error will pop:
Justification of the change:
In my consideration, both
includeSelectors
andincludeTemplates
are not needed. It does work without using them. But the behaviour ofcommonLabels
(referring to old method) will useincludeSelectors
andincludeTemplates
mandatory, while these are not necessary at all.If the team believes
includeSelectors
andincludeTemplates
are needed, please comment so and I will add them.