Add test_suite and test_config under conformance #441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/gcbrun |
|
|
||
| // Representation of a CEL Environment, defining what features and extensions | ||
| // are available for conformance testing. | ||
| message Environment { |
There was a problem hiding this comment.
Can we update the Environment definition to be closer to what we support as a YAML serialization format for cel-go? e.g.
https://github.com/google/cel-go/blob/69febe24b1f09fb654923ee5cfae6cb8f0ddeb26/common/env/testdata/extended_env.yaml
| option java_package = "cel.dev.expr.conformance"; | ||
|
|
||
| // The format of test suite for CEL tests. | ||
| message TestSuite { |
There was a problem hiding this comment.
We should probably look at proto/cel/expr/conformance/test as the place to include these files. Also, it should be clear how this aligns with or supercedes the simple.proto in the test directory
| import "cel/expr/value.proto"; | ||
|
|
||
| option cc_enable_arenas = true; | ||
| option go_package = "cel.dev/expr/conformance"; |
There was a problem hiding this comment.
Let's update the package to cel.dev/expr/conformance/test and bump the files here down a level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding test_suite and test_config protos under conformance package. These protos define: