Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Added type property in ChartDataSets to support mixed charts #19

Closed
wants to merge 3 commits into from
Closed

Added type property in ChartDataSets to support mixed charts #19

wants to merge 3 commits into from

Conversation

portno
Copy link

@portno portno commented Dec 13, 2017

Didn't find any other way to do it.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If your company signed a CLA, they designated a Point of Contact who decides which employees are authorized to participate. You may need to contact the Point of Contact for your company and ask to be added to the group of authorized contributors. If you don't know who your Point of Contact is, direct the project maintainer to go/cla#troubleshoot.
  • In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again.

@portno
Copy link
Author

portno commented Dec 13, 2017

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@kevmoo
Copy link
Contributor

kevmoo commented Mar 15, 2018

Which version of chart.js was this introduced in?

@portno
Copy link
Author

portno commented Mar 15, 2018

According to this release it was added in version 2.0.0, Charts that combine visual types such as bars and lines. Also, they mention mixed chart types in their official website as New in 2.0

@kevmoo
Copy link
Contributor

kevmoo commented Mar 21, 2018

I just pushed an update that should include chart.js 2.6

Please take a look at master and compare...

@portno
Copy link
Author

portno commented Mar 22, 2018

The type property exists. Please close this PR.

I've created another issue with feedback. #22

@kevmoo kevmoo closed this Mar 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants