Skip to content
This repository has been archived by the owner on Nov 29, 2023. It is now read-only.

Added factory for ChartXAxe and ChartYAxe #32

Merged
merged 1 commit into from
Nov 12, 2018

Conversation

zarisi
Copy link
Contributor

@zarisi zarisi commented Nov 9, 2018

Added missing factory for the classes ChartXAxe and ChartYAxe from the issue #26

Fixed error with author mail from PR #31

Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you validated that this works?

@zarisi
Copy link
Contributor Author

zarisi commented Nov 12, 2018

I tried it in my code and it seems to work without problems

@kevmoo kevmoo merged commit ed97605 into google:master Nov 12, 2018
@basevers
Copy link

I'm guessing the same applies for "TickOptions".
Will create a separate issue for this.

@computmaxer
Copy link

@kevmoo could you publish a released with the latest factory constructor fixes? (Mainly interested in this and #29)

I would greatly appreciate it, thanks!

@computmaxer
Copy link

@kevmoo can we tag a release? Would love to remove the dependency_override for this package from my app 😄

@kevmoo
Copy link
Contributor

kevmoo commented Feb 24, 2019

Sorry for the lag here. Happy to tag and publish!

@kevmoo
Copy link
Contributor

kevmoo commented Feb 24, 2019

published as 0.5.1

@computmaxer
Copy link

Thanks Kevin!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants