Delete CheckDefaultExportOfGoogModule.

This is now more of a hinderance than a benefit the TypeScript tooling will translate it to the expected pattern. PiperOrigin-RevId: 716742693
google · Jan 17, 2025 · a21cc0f · a21cc0f
1 parent 35b2d79
commit a21cc0f
Show file tree

Hide file tree

Showing 5 changed files with 0 additions and 255 deletions.
diff --git a/src/com/google/javascript/jscomp/DefaultPassConfig.java b/src/com/google/javascript/jscomp/DefaultPassConfig.java
@@ -43,7 +43,6 @@
 import com.google.javascript.jscomp.lint.CheckArrayWithGoogObject;
 import com.google.javascript.jscomp.lint.CheckConstPrivateProperties;
 import com.google.javascript.jscomp.lint.CheckConstantCaseNames;
-import com.google.javascript.jscomp.lint.CheckDefaultExportOfGoogModule;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;
 import com.google.javascript.jscomp.lint.CheckEnums;
@@ -1947,7 +1946,6 @@ public void process(Node externs, Node root) {
                     ImmutableList.<NodeTraversal.Callback>builder()
                         .add(new CheckConstPrivateProperties(compiler))
                         .add(new CheckConstantCaseNames(compiler))
-                        .add(new CheckDefaultExportOfGoogModule(compiler))
                         .add(new CheckEmptyStatements(compiler))
                         .add(new CheckEnums(compiler))
                         .add(new CheckEs6ModuleFileStructure(compiler))

diff --git a/src/com/google/javascript/jscomp/DiagnosticGroups.java b/src/com/google/javascript/jscomp/DiagnosticGroups.java
@@ -32,7 +32,6 @@
 import com.google.javascript.jscomp.lint.CheckArrayWithGoogObject;
 import com.google.javascript.jscomp.lint.CheckConstPrivateProperties;
 import com.google.javascript.jscomp.lint.CheckConstantCaseNames;
-import com.google.javascript.jscomp.lint.CheckDefaultExportOfGoogModule;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;
 import com.google.javascript.jscomp.lint.CheckEnums;
@@ -555,8 +554,6 @@ public static DiagnosticGroup forName(String name) {
               CheckConstPrivateProperties.MISSING_CONST_PROPERTY,
               CheckConstantCaseNames.REASSIGNED_CONSTANT_CASE_NAME,
               CheckConstantCaseNames.MISSING_CONST_PROPERTY,
-              CheckDefaultExportOfGoogModule.DEFAULT_EXPORT_IN_GOOG_MODULE,
-              CheckDefaultExportOfGoogModule.MAYBE_ACCIDENTAL_DEFAULT_EXPORT_IN_GOOG_MODULE,
               CheckEmptyStatements.USELESS_EMPTY_STATEMENT,
               CheckEnums.COMPUTED_PROP_NAME_IN_ENUM,
               CheckEnums.DUPLICATE_ENUM_VALUE,

diff --git a/src/com/google/javascript/jscomp/LintPassConfig.java b/src/com/google/javascript/jscomp/LintPassConfig.java
@@ -18,7 +18,6 @@
 import com.google.common.collect.ImmutableList;
 import com.google.javascript.jscomp.lint.CheckConstPrivateProperties;
 import com.google.javascript.jscomp.lint.CheckConstantCaseNames;
-import com.google.javascript.jscomp.lint.CheckDefaultExportOfGoogModule;
 import com.google.javascript.jscomp.lint.CheckDuplicateCase;
 import com.google.javascript.jscomp.lint.CheckEmptyStatements;
 import com.google.javascript.jscomp.lint.CheckEnums;
@@ -90,7 +89,6 @@ protected PassListBuilder getFinalizations() {
                       ImmutableList.of(
                           new CheckConstPrivateProperties(compiler),
                           new CheckConstantCaseNames(compiler),
-                          new CheckDefaultExportOfGoogModule(compiler),
                           new CheckDuplicateCase(compiler),
                           new CheckEmptyStatements(compiler),
                           new CheckEnums(compiler),

diff --git a/src/com/google/javascript/jscomp/lint/CheckDefaultExportOfGoogModule.java b/src/com/google/javascript/jscomp/lint/CheckDefaultExportOfGoogModule.java
diff --git a/test/com/google/javascript/jscomp/lint/CheckDefaultExportOfGoogModuleTest.java b/test/com/google/javascript/jscomp/lint/CheckDefaultExportOfGoogModuleTest.java