Set component id if a numeric component is available in the component… #4008
Conversation
|
@rmistry is there a way to get a componentid from component tag? |
| # Set the componentId to the first encountered numeric component | ||
| # in the component list. | ||
| for component in list(self.components): | ||
| if component.isnumeric(): |
There was a problem hiding this comment.
hmmm...will component ever be an int? this will fail in that case.
There was a problem hiding this comment.
It will not be an int, we are doing the same thing a few lines above:
jonathanmetzman
force-pushed
the
master
branch
3 times, most recently
from
e7e91a0
to
22e1108
Compare
Interesting bugs for this area are b/315853316 and b/318504348 At the time those were submitted, predator returned full component paths, but infrastructure was added to make sure that whenever Chromium's I don't think you can get a |
| # in the component list. | ||
| for component in list(self.components): | ||
| if component.isnumeric(): | ||
| self._data['issueState']['componentId'] = int(component) |
There was a problem hiding this comment.
According to this it will set the first component that predator returns. It would be worth looking in logs for components in predator responses to see what is being returned. Maybe the first is not what we want, but it is likely impossible to say what we want.
Perhaps a better way to handle this is to say iff the size of self.components is 1 then set the componentId, otherwise leave it alone.
There was a problem hiding this comment.
Though as mentioned in b/341800538#comment8 the PEEPs bot is probably setting things to the 1st component anyway (would be good to verify what actually happens).
… list