Updating deploy script for downloading internal_issue_tracker module from GCS #4702
+30
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Javan Lacerda <[email protected]>
javanlacerda
requested review from
jonathanmetzman,
oliverchang and
vitorguidi
and removed request for
jonathanmetzman
javanlacerda
force-pushed
the
javan.download_issuer_tracker
branch
from
eb01d54 to
7c13b92
Compare
Signed-off-by: Javan Lacerda <[email protected]>
javanlacerda
force-pushed
the
javan.download_issuer_tracker
branch
from
7c13b92 to
634e4d9
Compare
| @@ -161,6 +161,14 @@ def sub_config(self, path): | |||
|
|
|||
| return Config(root=new_root) | |||
|
|
|||
| # it returns that the config is for internal, external or google | |||
There was a problem hiding this comment.
Nit: start with a capital letter and end with a period.
| @@ -161,6 +161,14 @@ def sub_config(self, path): | |||
|
|
|||
| return Config(root=new_root) | |||
|
|
|||
| # it returns that the config is for internal, external or google | |||
| # TODO: add and get this information from the project.yaml file | |||
There was a problem hiding this comment.
Nit: Put a username or issue number here. e.g. TODO(metzman):
| @@ -238,6 +238,12 @@ def _deploy_zip(bucket_name, zip_path, test_deployment=False): | |||
| os.path.basename(zip_path))) | |||
|
|
|||
|
|
|||
| def _download_zip(bucket_name, gcs_file_path, target_path): | |||
| """Download zip from GCS.""" | |||
| common.execute( | |||
| # code to be able to open the clusterfuzz-config code. | ||
| # This workaround manages to download the internal_issue_tracker module from | ||
| # GCS during the deployment. | ||
| if config.get_target() == "google": |
There was a problem hiding this comment.
nit: single quotes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is updating the butler deploy to download and unpack the internal_issue_tracker module from GCS for Google project deployments.
It's being needed because there's some sensitive code into the internal_issue_tracker module and we want to open the clusterfuzz-config code.
It was tested by running the butler deploy locally with the internal_issue_tracker module deleted, and it managed to "recreate" the module properly.