Ensure regression tasks don't start new tasks when not making progress #4705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This returns a bad-build error type after a regression task, when a known min/max input pair didn't shrink. Previously, a timeout error type was returned, after which post-process respawns the task with the same min/max pair, leading to a task loop.
This doesn't change behavior when either min or max are not known (e.g. when tasks are initially started) or when some progress is made (e.g. at least one improvement to min or max during several hours this task can run) or when other error conditions happen.
Chrome bug: https://crbug.com/396344382