Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SVG renders in RTL contents #1454

Merged

Conversation

moaminsharifi
Copy link
Collaborator

Part of:
#671
#1433

Issue:

When we render SVG tags in persian ( <html dir="rtl" ...>) make confiliect:

svg-rtl-issue
originally: 7.2 Arrays and for Loops
svg-rtl-issue-2

originally: 16.2 Moved Strings in Rust

Proposed method:

as we talked in #1433, again in there adding

[dir="rtl"] svg {
  direction: ltr;
}

fix issue like:

svg-rtl-issue-fix

svg-rtl-issue-2-fixture

Copy link
Collaborator

@mgeisler mgeisler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, makes sense to me!

@mgeisler mgeisler changed the title fixture for svg renders in rtl contents Fix SVG renders in RTL contents Nov 8, 2023
@moaminsharifi moaminsharifi merged commit 7cec167 into google:main Nov 8, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants