-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
vi: Translate TOC from Running the course to the end of Chromium #1948
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
16b9221
to
9b58862
Compare
59575f1
to
a8f9b5e
Compare
Hi @ichxorya, thanks a lot for helping out here! I believe you need to install @daivinhtran, will be you be able to review this PR? You can also help @ichxorya by reformatting it on your machine (use |
Hello, I believe that I used dprint to format the file (ichxorya@a8f9b5e) |
Yes, it's very difficult or impossible to translate everything. We don't have a unified approach to this: I think it's fine to keep the English word in parenthesis after the translated word. Perhaps like this:
where the English word is in italics and the rest is normal. |
@ichxorya To distribute the work easier, would mind splitting the PR into smaller PRs to avoid spanning the translation across too many |
How should I do that? Can you suggest? This pr is already too large from the beginning. For now I could close this pr and restart on a smaller range of translation like other pr, if it helps. |
Yeah I think opening a new PR with translation for a small set of |
If you need to split up the work, then I know two approaches:
The Gettext tools are a bit clunky, but they can be good if you want to operate on hundreds of entries spread across the PO file. If you only want to deal with a few hand-fulls of messages, then I suggest lots of copy-paste 😄 |
Hi @ichxorya and @daivinhtran, would one of you be up for reviewing this? I have update it to resolve the merge conflicts. What I did:
|
Oh, that was supposed to be the last step, but I also had to merge |
The PR is now very small and can actually be reviewed in GitHub! It would be awesome if the two of you could finish this so we can merge it. |
I would love to check the commit soon, thank you. However, I'm afraid my contribution has been "outdated" (some were translated after I draft this PR). How did you manage to resolve it? |
From what I can tell on GitHub, there are no conflicts — the PR will merge cleanly. So you should just un-draft it and get someone to look it over 🎉 |
@daivinhtran, could you skim through this one? |
I tried to translate the table of contents into Vietnamese.