Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty structs #2569

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Add empty structs #2569

merged 1 commit into from
Jan 22, 2025

Conversation

djmitche
Copy link
Collaborator

This should be quick, but introduces the syntax and the concept of a ZST.

@djmitche djmitche requested a review from hurryabit January 19, 2025 07:54
Copy link
Collaborator

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not convinced this is super useful. I think the concept is so simple that we can explain it in passing when we need it for the first time. Adding an additional slide here costs more time and probably increases increments mental load without much benefit.

@djmitche
Copy link
Collaborator Author

Fair point -- I'll adjust this to only mention it in the notes for tuple structs. I think it's worth at least mentioning ZSTs.

@djmitche djmitche force-pushed the empty-structs branch 2 times, most recently from 38c3451 to 81bec9b Compare January 21, 2025 21:28
@djmitche djmitche requested a review from hurryabit January 21, 2025 21:29
@djmitche djmitche enabled auto-merge (squash) January 22, 2025 10:42
Copy link
Collaborator

@hurryabit hurryabit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That works for me. Thanks for being so understanding. :)

@djmitche djmitche merged commit 5b03ea6 into google:main Jan 22, 2025
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants