use Cargo.lock version for mdbook in the CI #2623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not working in the current way. The issue #2620 needs some more discussion on the best approach |
michael-kerscher
force-pushed
the
cargo-lock-ci-sync
branch
from
75a3e55 to
4ec2579
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #2620 and forces usage of the versions specified in Cargo.lock
The benefit would be to have the same versions in the CI that the developers use on their systems
What are the reasons for the manually locked versions in the CI?
Discussion might be necessary for how to best solve the issue for why this was locked.
We could configure dependabot to ignore mdbook related updates so we can update these versions manually.