Add Tensorstore back to required dependencies. #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was reversed back when user reported google#2341, but it was now fixed and verified.
cgarciae
approved these changes
Oct 11, 2022
|
tensorstore build fails google/tensorstore#63 for me -- on python 3.10 and 3.11 (Linux). I think this is an optional dependency for an optional feature; can we mark this dep as optional? |
4 tasks
wookayin
added a commit
to wookayin/flax
that referenced
this pull request
Dec 7, 2022
tensorstore is an optional dependency for flax. In google#2520 it was added back as the normal dependency, but on some Linux and macOS environments tensorstore still fails to build (see google#2341, google/tensorstore#63).
|
tensorstore should be dropped from flax's dependency. Submitted a PR #2692 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was reversed back when user reported #2341, but it was now fixed and verified.