[nnx] add FSDP toy example with custom optimizer #4183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvyZX
approved these changes
Sep 13, 2024
cgarciae
force-pushed
the
nnx-fsdp-toy-example
branch
3 times, most recently
from
142402c
to
6eb75b1
Compare
cgarciae
force-pushed
the
nnx-fsdp-toy-example
branch
2 times, most recently
from
10b557b
to
b5acbbf
Compare
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
cgarciae
force-pushed
the
nnx-fsdp-toy-example
branch
from
b5acbbf
to
f7d3873
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds toy example showing how to do a very simple FSDP and shows how to create a custom SGD optimizer with momentum (no optax).