Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Flax NNX Haiku Linen migration doc #4200

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

8bitmp3
Copy link
Collaborator

@8bitmp3 8bitmp3 commented Sep 16, 2024

No description provided.

@8bitmp3 8bitmp3 closed this Oct 6, 2024
@8bitmp3 8bitmp3 reopened this Oct 6, 2024
@8bitmp3 8bitmp3 requested review from IvyZX and cgarciae October 6, 2024 20:44
@8bitmp3 8bitmp3 self-assigned this Oct 6, 2024
@@ -21,18 +27,18 @@ provide a more intuitive development experience.
# TODO: make sure code lines are not too long
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cgarciae @IvyZX Pre-commit trailing whitespace check - no ✅ Could it be because of the reStructuredCode formatting like here or in code snippets?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fixed.

@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 15, 2024

Moving to draft after discussing with @IvyZX . Will reopen soon after certain changes by @IvyZX.

@8bitmp3 8bitmp3 marked this pull request as draft October 15, 2024 22:56
@8bitmp3
Copy link
Collaborator Author

8bitmp3 commented Oct 18, 2024

#4305 has been merged!

@8bitmp3 8bitmp3 reopened this Oct 28, 2024
@8bitmp3 8bitmp3 marked this pull request as ready for review October 28, 2024 21:24
Copy link
Collaborator

@IvyZX IvyZX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@copybara-service copybara-service bot merged commit 0679702 into google:main Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants