Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating primitives names in cells directory #32

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Updating primitives names in cells directory #32

wants to merge 25 commits into from

Conversation

FaragElsayed2
Copy link
Collaborator

@FaragElsayed2 FaragElsayed2 commented Aug 11, 2022 •
edited
Loading

Fixes #1

  • Renaming all primitives with its new name except [resistors / sc_diode] in the following directory
    • globalfoundries-pdk-libs-gf180mcu_fd_pr/cells

atorkmabrains
atorkmabrains approved these changes Aug 11, 2022
View reviewed changes
Copy link
Collaborator

@atorkmabrains atorkmabrains left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mithro I'm approving this change.

@FaragElsayed2 FaragElsayed2 changed the title Updating primitves names part1 Updating primitives names in cells directory Aug 21, 2022
@FaragElsayed2
Copy link
Collaborator Author

FaragElsayed2 commented Aug 31, 2022 •
edited
Loading

@mithro Changes are completed including cap_mim as you agreed with @atorkmabrains

atorkmabrains and others added 19 commits October 18, 2022 10:22
@atorkmabrains
- Update to resistor regression and fixing resistors issue for most o…
ebaee18 
…f the resistor devices.
@atorkmabrains
- Deleting unused netlists.
7d57bdb
@atorkmabrains
- Adding new simulation template.
b8fd490
@atorkmabrains
Merge pull request #3 from mabrains/resistors_fix
92fc5ea 
Fixing Resistor Models to work properly for ngspice
@mohanad0mohamed
Adding script that convert gds2txt back and forth
7c5973a
@mohanad0mohamed
Modifying MOSFET Pcell Bulk Tie
e54547b
@mohanad0mohamed
Adding drop down menu for klayout
b781c9f
@atorkmabrains
Merge pull request #4 from mabrains/dropdown_menu
aa394e8 
Adding drop down menu for klayout
@mohanad0mohamed
Adding drop down menu for klayout
0fd53c8
@mohanad0mohamed
Modifying Metaltop rules MT.2b and MT30.6
8cda432
@atorkmabrains
- Minor update to resistor regression to clean up reporting.
49c8d00
@atorkmabrains
Merge pull request #5 from mabrains/resistors_fix
42cf88f 
Fixing all resistor issues.
@atorkmabrains
Merge pull request #6 from mabrains/metaltop_rules
9aa03a3 
Adding missing Metaltop rules MT.2b and MT30.6
@atorkmabrains
Merge branch 'main' into dropdown_menu
110fb83 
Signed-off-by: atorkmabrains <[email protected]>
@atorkmabrains
Merge pull request #7 from mabrains/dropdown_menu
94c614d 
Adding drop down menu for klayout for ease of use of the PDK.
@atorkmabrains
Merge pull request #8 from mabrains/mos_pcell
464ac3a 
Fixing MOSFET Pcell Bulk Tie
@atorkmabrains
Merge pull request #9 from mabrains/gds2txt
7ea0a74 
Adding script that convert gds2txt back and forth
@atorkmabrains
Merge pull request #10 from mabrains/primitives_names_part2
a41eae1 
Updating primitves names for models files
@atorkmabrains
Merge pull request #11 from mabrains/primitives_names_part3
1b7ace2 
 Updating primitves names in lvs rule deck and its README file
atorkmabrains and others added 2 commits November 8, 2022 10:57
@atorkmabrains
Merge pull request #12 from mabrains/primitives_names_part4
93e3836 
Updating primitives names in [ip , manual, extraction checking] testc…
@atorkmabrains
- Updating primitives names.
2806abe
@proppy proppy mentioned this pull request Nov 11, 2022
Open
atorkmabrains added a commit to christoph-weiser/globalfoundries-pdk-libs-gf180mcu_fd_pr that referenced this pull request Dec 18, 2022
@atorkmabrains
Merge pull request google#32 from efabless/main
8820ea9 
Update run_drc_parallel.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atorkmabrains atorkmabrains atorkmabrains approved these changes

@mithro mithro Awaiting requested review from mithro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix the naming of the primitives to be consistent with skywater-pdk format.
3 participants
@FaragElsayed2 @atorkmabrains @mohanad0mohamed