-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci/Tests: use a container image to avoid installing klayout in each job #54
Conversation
Signed-off-by: Unai Martinez-Corral <[email protected]>
This pull request needs to be rebased before we can merge. |
@mithro this rebase and merge process will be extremely painful process due to the long standing PR list. We will have to redo many many times. Please give me admin access on this repo to finalize all changes. |
@@ -48,36 +50,33 @@ jobs: | |||
name: ${{ matrix.type }} | ${{ matrix.test }} | |||
|
|||
env: | |||
PDK_ROOT: $GITHUB_WORKSPACE/rules/klayout | |||
PDK: ${{ matrix.pdk }} | |||
IMAGE: ghcr.io/google/globalfoundries-pdk-libs-gf180mcu_fd_pr/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is the image public?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image is neither public nor private, because it's not pushed to any registry. It's built in one step and used in the next step, both of them executed within the same job. Therefore, the name might be anything; it's local only.
However, it might make sense to eventually split building the image and using it, in order to avoid installing the dependencies in each job. That's what #55 is about.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah make sense, curious if you consider caching it with docker save/load
instead?
@proppy The name change PRs are very extensive. We will have to do the rebase and merge many many times. |
I believe that github only mandate a rebase when it detect a conflict, see https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/about-merge-methods-on-github |
@proppy I know that. Name change will definitely create conflicts. This a major change and work that I want to avoid. |
add notebooks to plot the measurements against the simulation
Closing per #30 (comment). |
Thanks @umarcor Appreciate your work. Was really helpful. |
Fixes #30
/cc @atorkmabrains