Docstore/awsdynamodb: Supporting the AWS V2 SDK #3519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erences to aws sdk v2
…zation and changed error type
…es, returning that concrete type to avoid unnecessary type assertion
…eatable outside of CI
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
jba
reviewed
Jan 31, 2025
There was a problem hiding this comment.
We appreciate the effort you put into this. However, there is a lot of changed code here, including at least two breaking changes. How does the docstore user benefit from the switch to the new API?
Note that the breaking changes are unlikely to be approved, because they would require a v2 of the main module.
| @@ -36,6 +37,7 @@ aws dynamodb create-table \ | |||
| # The docstore-test-2 table has both a partition and a sort key, and two indexes. | |||
|
|
|||
| aws dynamodb create-table \ | |||
| --region us-east-2 \ | |||
| @@ -75,8 +69,6 @@ const Scheme = "dynamodb" | |||
| // See https://godoc.org/gocloud.dev/aws#ConfigFromURLParams for supported query | |||
| // parameters for overriding the aws.Session from the URL. | |||
| type URLOpener struct { | |||
| // ConfigProvider must be set to a non-nil value. | |||
| if err != nil { | ||
| return nil, "", "", "", nil, fmt.Errorf("open collection %s: %v", u, err) | ||
| } | ||
| return db, tableName, partitionKey, sortKey, opts, nil | ||
| } | ||
|
|
||
| // Dial gets an AWS DynamoDB service client. | ||
| func Dial(p client.ConfigProvider) (*dyn.DynamoDB, error) { | ||
| if p == nil { | ||
| func Dial(p aws.Config) (*dyn.Client, error) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved #3458
A somewhat quick and dirty conversion to using the AWS V2 SDK rather than the deprecated V1.
Due to the delays in my finding time to work on this I prioritised getting the functionality migrated to mitigate any risk from API drift form the deprecated V1 SDK.
The main sections that warrant further discussion:
V2ConfigFromURLParams, but is worth review