Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing map tests #181

Merged
merged 3 commits into from
Nov 12, 2020

Conversation

mlevesquedion
Copy link
Contributor

@mlevesquedion mlevesquedion commented Nov 10, 2020

This PR adds (currently failing) tests for MapUpdate as well as the delete operation on maps.

Specifically, this adds three (negative) cases:

  • Deleting a key (delete(map, key)) from a map does not taint the key
  • Updating a map with a tainted value (map[key] = value) does not taint the key
  • Updating a map with a tainted key (map[key] = value) does not taint the value

The first case exercises some behavior involving Call instructions.

The 2nd and 3rd cases validate that when propagating to a MapUpdate operation, only the Map is tainted (the positive case is already covered by other tests).

This PR is a precursor to #178.

  • Tests pass
  • (N/A) [ ] Running against a large codebase such as Kubernetes does not error out.
  • (N/A) [ ] Appropriate changes to README are included in PR

@mlevesquedion mlevesquedion merged commit 2912f1f into google:master Nov 12, 2020
@mlevesquedion mlevesquedion deleted the add-map-update-tests branch November 12, 2020 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants