Avoid stack overflow in sourcetype.IsSourceType. #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlevesquedion
force-pushed
the
avoid-sourcetype-stack-overflow
branch
from
8edc7b2 to
80fd612
Compare
vinayakankugoyal
approved these changes
Jul 12, 2021
mlevesquedion
force-pushed
the
avoid-sourcetype-stack-overflow
branch
from
1979b67 to
84e6b31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #320.
In my understanding, a stack overflow can occur whenever we have a value of a type that is self-referential. Not all self-referential types are allowed by the compiler, e.g.
type A A(which is nonsensical) is not allowed, buttype A map[string]Ais allowed (consider a tree-like type).This PR adds a
map[types.Type]boolof seen types to the type traversal to handle any cyclical types.While testing this PR, I discovered a similar issue in
utils.Dereference, which leads to an infinite loop: #321.