Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete .bazelrc now that Bazel 7 is released #427

Merged
merged 3 commits into from
Dec 14, 2023

Conversation

cpsauer
Copy link
Contributor

@cpsauer cpsauer commented Dec 13, 2023

bzlmod is now enabled by default. Follows up on #412, cleaning things up :)

(Hopefully the GitHub images have been updated to 7.0 and the tests will pass. If not, maybe rerun in a month--still worth my posting the PR, I think, so we don't forget to do this cleanup at some point.)

Cheers,
Chris

bzlmod is now enabled by default. Follows up on google#412 :)
@cpsauer
Copy link
Contributor Author

cpsauer commented Dec 14, 2023

The images do indeed have Bazel 7 (looks like they use Bazelisk), so this is safe to merge on its own.

...but the build breakages are other Bazel 7-related issues, it looks like, that would break with HEAD w/ no code changes.
Not sure what's going on there. Bazel 7 should auto detect...perhaps a bug by them there.

Could be worth adding a .bazelversion file and having renovate auto-update? That way Bazel would always be on a working version.

@cpsauer
Copy link
Contributor Author

cpsauer commented Dec 14, 2023

Have filed underlying issue over at bazelbuild/bazel#20537

@cpsauer
Copy link
Contributor Author

cpsauer commented Dec 14, 2023

And worked around incompatible changes.

Lmk if you want help getting renovate to manage moving between bazel versions, so you never get silently broken by a Bazel update again.

Sketch: Just add a .bazelversion file pointing to a specific version and Renovate will pick it up. I'd advise using rolling (currently 8.0.0-pre.20231030.2) to hit issues before users like rules_apple does, and setting up auto updates so you don't go nuts having to approve a PR for a new bazel rolling version every week or two. In terms of Renovate config, you'd enable automatic merging for green builds as in #411 (comment), and let it track Bazel rolling (instead of normal releases) via

{
    "description": "Use rolling pre-releases for bazel itself.",
    "matchManagers": ["bazelisk"],
    "ignoreUnstable": false,
  }

Copy link
Member

@thomasvl thomasvl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@thomasvl thomasvl merged commit eba1cd2 into google:main Dec 14, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants