Use JsonIOException for unchecked exceptions instead of RuntimeExcept…

…ion in ConstructorConstructor
google · Oct 29, 2024 · cde8922 · cde8922
1 parent 44c9336
commit cde8922
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/gson/src/main/java/com/google/gson/internal/ConstructorConstructor.java b/gson/src/main/java/com/google/gson/internal/ConstructorConstructor.java
@@ -270,15 +270,13 @@ private static <T> ObjectConstructor<T> newDefaultConstructor(
       // Note: InstantiationException should be impossible because check at start of method made
       // sure that class is not abstract
       catch (InstantiationException e) {
-        throw new RuntimeException(
+        throw new JsonIOException(
             "Failed to invoke constructor '"
                 + ReflectionHelper.constructorToString(constructor)
                 + "' with no args",
             e);
       } catch (InvocationTargetException e) {
-        // TODO: don't wrap if cause is unchecked?
-        // TODO: JsonParseException ?
-        throw new RuntimeException(
+        throw new JsonIOException(
             "Failed to invoke constructor '"
                 + ReflectionHelper.constructorToString(constructor)
                 + "' with no args",