Use JsonIOException for unchecked exceptions instead of RuntimeExcept…

…ion in ConstructorConstructor
google · Oct 30, 2024 · e4471d0 · e4471d0
1 parent 44c9336
commit e4471d0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 6 deletions.
diff --git a/gson/src/main/java/com/google/gson/internal/ConstructorConstructor.java b/gson/src/main/java/com/google/gson/internal/ConstructorConstructor.java
@@ -270,15 +270,13 @@ private static <T> ObjectConstructor<T> newDefaultConstructor(
       // Note: InstantiationException should be impossible because check at start of method made
       // sure that class is not abstract
       catch (InstantiationException e) {
-        throw new RuntimeException(
+        throw new JsonIOException(
             "Failed to invoke constructor '"
                 + ReflectionHelper.constructorToString(constructor)
                 + "' with no args",
             e);
       } catch (InvocationTargetException e) {
-        // TODO: don't wrap if cause is unchecked?
-        // TODO: JsonParseException ?
-        throw new RuntimeException(
+        throw new JsonIOException(
             "Failed to invoke constructor '"
                 + ReflectionHelper.constructorToString(constructor)
                 + "' with no args",

diff --git a/gson/src/test/java/com/google/gson/functional/ObjectTest.java b/gson/src/test/java/com/google/gson/functional/ObjectTest.java
@@ -727,10 +727,9 @@ static class ClassWithStaticFinalField {
 
   @Test
   public void testThrowingDefaultConstructor() {
-    // TODO: Adjust this once Gson throws more specific exception type
     var e =
         assertThrows(
-            RuntimeException.class, () -> gson.fromJson("{}", ClassWithThrowingConstructor.class));
+            JsonIOException.class, () -> gson.fromJson("{}", ClassWithThrowingConstructor.class));
     assertThat(e)
         .hasMessageThat()
         .isEqualTo(