Enforce rawType to be a Class in ParameterizedTypeImpl

google · Oct 12, 2024 · f03717f · f03717f
1 parent 7e98ebd
commit f03717f
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/gson/src/main/java/com/google/gson/internal/$Gson$Types.java b/gson/src/main/java/com/google/gson/internal/$Gson$Types.java
@@ -520,9 +520,12 @@ private static final class ParameterizedTypeImpl implements ParameterizedType, S
     private final Type[] typeArguments;
 
     public ParameterizedTypeImpl(Type ownerType, Type rawType, Type... typeArguments) {
-      // TODO: Should this enforce that rawType is a Class? See JDK implementation of
-      // the ParameterizedType interface and https://bugs.openjdk.org/browse/JDK-8250659
       requireNonNull(rawType);
+
+      if (!(rawType instanceof Class)) {
+        throw new IllegalArgumentException("rawType must be a Class type");
+      }
+
       if (ownerType == null && requiresOwnerType(rawType)) {
         throw new IllegalArgumentException("Must specify owner type for " + rawType);
       }