Replace anonymous class creation with lambdas in ConstructorConstructor #2763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm, I noticed odd that the I assume it's not related to the change? |
Seems to be a bug with that GitHub action; I have created #2764 to update it a fixed version. Once that is merged you can merge |
Marcono1234
reviewed
Oct 16, 2024
There was a problem hiding this comment.
Thanks for the changes! I have one small suggestion, see review comment.
Though @eamonnmcmanus might have additional suggestions or requests for changes.
gson/src/main/java/com/google/gson/internal/ConstructorConstructor.java
Outdated
Show resolved
Hide resolved
panic08
force-pushed
the
replace-anonymous-class-creation-with-lambdas-in-ConstructorConstructor
branch
from
30ba3be
to
56217ed
Compare
gson/src/test/java/com/google/gson/internal/ConstructorConstructorTest.java
Outdated
Show resolved
Hide resolved
Replace anonymous class creation with lambdas in ConstructorConstructor Replace anonymous class creation with lambdas in ConstructorConstructor Replace anonymous class creation with lambdas in ConstructorConstructor
panic08
force-pushed
the
replace-anonymous-class-creation-with-lambdas-in-ConstructorConstructor
branch
from
56217ed
to
a022037
Compare
…s-in-ConstructorConstructor
eamonnmcmanus
approved these changes
Oct 18, 2024
panic08
deleted the
replace-anonymous-class-creation-with-lambdas-in-ConstructorConstructor
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should change the complete creation of anonymous classes to lambdas, which will reduce the amount of code and make it more readable
Since we recently got Java 8 support, we can afford to use lambdas