Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify equality checks using Objects.equals in PostConstructAdapterFactoryTest #2767

Merged
merged 1 commit into from
Oct 21, 2024
Merged

Simplify equality checks using Objects.equals in PostConstructAdapterFactoryTest #2767

merged 1 commit into from
Oct 21, 2024

Conversation

panic08
Copy link
Contributor

@panic08 panic08 commented Oct 18, 2024

Here we replace manual checks by using Objects.equals(), which reduces the amount of code and makes it more readable

eamonnmcmanus
eamonnmcmanus approved these changes Oct 21, 2024
View reviewed changes
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eamonnmcmanus eamonnmcmanus merged commit 44c9336 into google:main Oct 21, 2024
11 checks passed
@panic08 panic08 deleted the simplify-equality-checks-in-PostConstructAdapterFactoryTest branch October 26, 2024 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@panic08 @eamonnmcmanus