Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use better names for lambda parameters in tests #2770

Merged
merged 1 commit into from
Oct 20, 2024
Merged

Use better names for lambda parameters in tests #2770

merged 1 commit into from
Oct 20, 2024
+4 −2

Conversation

Marcono1234
Copy link
Collaborator

Purpose

Follow-up for #2766

Description

Without the parameter type it is difficult to understand what some of the lambda parameters represent, therefore I have renamed them.

eamonnmcmanus
eamonnmcmanus approved these changes Oct 20, 2024
View reviewed changes
Copy link
Member

@eamonnmcmanus eamonnmcmanus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fair. The short names are the same as the ones that were used before this code was converted to use lambdas, though there we did at least have their types.

@eamonnmcmanus eamonnmcmanus merged commit e430a3d into google:main Oct 20, 2024
11 checks passed
@Marcono1234 Marcono1234 deleted the marcono1234/test-lambda-param-names branch October 21, 2024 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eamonnmcmanus eamonnmcmanus eamonnmcmanus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Marcono1234 @eamonnmcmanus