Fix Javadoc search on JDK 11: #5805
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
Fixed Javadoc search feature on JDK 11, which is currently used in our scripts updating snapshot Javadocs on guava.dev and building Guava releases, by adding `no-module-directories` flag. This option is not present in javadoc tool from JDK 8 and 13+, hence we use profiles to conditionally pass this flag on 9-12 only. Note that on JDK 17 javadoc generation does not work, as it seems to have changed the warning on LVTI usage in sources to an error. Fixes #5457 Fixes #5800 RELNOTES=n/a PiperOrigin-RevId: 413922237
copybara-service
bot
force-pushed
the
test_413922237
branch
2 times, most recently
from
5c2b67d
to
3072f4f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Javadoc search on JDK 11:
Fixed Javadoc search feature on JDK 11, which is currently used in our
scripts updating snapshot Javadocs on guava.dev and building
Guava releases, by adding
no-module-directoriesflag.This option is not present in javadoc tool from JDK 8 and 13+,
hence we use profiles to conditionally pass this flag on 9-12 only.
Note that on JDK 17 javadoc generation does not work,
as it seems to have changed the warning on LVTI usage in sources
to an error.
Fixes #5457
Fixes #5800
RELNOTES=n/a