Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify the protocols for 'constant' bindings #1858

Closed
wants to merge 0 commits into from

Conversation

copybara-service[bot]
Copy link

Simplify the protocols for 'constant' bindings

  • accept an InternalContext parameter from Initializable.get which all callers can provide.
    • This speeds up the injectAll phrase of injector creation since we no longer need to create an InternalContext object for each instance binding.
  • for 'constant' bindings with no injection points use a simpler set of InternalFactory types.
    • This provides some immediate benefits by eliminating indirection (though admittedly the impacts are minor), but when we adopt method handles this will enable a cheaper implementation there as well.

@copybara-service copybara-service bot closed this Jan 13, 2025
@copybara-service copybara-service bot deleted the test_714690364 branch January 13, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants