Fix various issues around Resolver.getJavaWildcard #2304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which aligns with KSP1.
Some out variance was incorrectly optimized away.
This was
linked to
issues
Jan 25, 2025
dx404
approved these changes
Jan 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
outvariances are incorrectly optimized away. [ksp2] getJavaWildcard does not return wildcard for List param (different with kapt/ksp1) #2264and also
4. Fixed type expansion; previously some type parameters were not substituted.
5. KSP1: KSTypeArgument.parent should be KSClassifierReference, instead of KSTypeReference.
finally,
6. Enabled the remaining tests around Resolver.getJavaWildcard.