Skip to content

Commit

Permalink
Fix nightly lints (#880)
Browse files Browse the repository at this point in the history
Also do not fail the workflow when nightly fails. The situations where the nightly job fails but the
stable job doesn't, shouldn't block merging a PR. In particular, nightly is not hermetic (by
design), so shouldn't block merging a PR for this simple reason alone.

Fixes #867
  • Loading branch information
ia0 authored Jan 20, 2025
1 parent 6896a43 commit 8eb86c1
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
1 change: 1 addition & 0 deletions .github/workflows/rust-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ jobs:
working-directory: rust
test:
runs-on: ubuntu-latest
continue-on-error: ${{ matrix.toolchain == 'nightly' }}
strategy:
matrix:
toolchain: [stable, nightly]
Expand Down
2 changes: 1 addition & 1 deletion rust/gen/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ fn main() -> Result<()> {
let model_name = std::fs::read_link("model")?;
let model_name = model_name
.components()
.last()
.next_back()
.context("model link")?
.as_os_str()
.to_str()
Expand Down

0 comments on commit 8eb86c1

Please sign in to comment.