Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable some warnings when building ONNX Runtime #894

Merged
merged 1 commit into from
Jan 22, 2025
Merged

Conversation

ia0
Copy link
Member

@ia0 ia0 commented Jan 21, 2025

GCC 14 is either better at detecting uninitialized issues or has false positives, compared to GCC 13. Those warnings are considered as errors, so we disable them.

@ia0 ia0 force-pushed the onnx branch 7 times, most recently from 53ae61d to 3eaf845 Compare January 21, 2025 16:23
@ia0
Copy link
Member Author

ia0 commented Jan 21, 2025

The problem is the manylinux container: pypa/manylinux#1730

@ia0
Copy link
Member Author

ia0 commented Jan 21, 2025

It might be simpler to figure out how to remove -Werror=maybe-uninitialized.

@ia0 ia0 force-pushed the onnx branch 3 times, most recently from 26fb6ff to e7c0527 Compare January 22, 2025 10:26
@ia0 ia0 changed the title Force cmake version when build ONNX Runtime Disable some warnings when building ONNX Runtime Jan 22, 2025
@ia0 ia0 marked this pull request as ready for review January 22, 2025 11:08
@reyammer
Copy link
Collaborator

Thanks for tracking this down!

@reyammer reyammer merged commit d5c4089 into google:main Jan 22, 2025
14 checks passed
@ia0 ia0 deleted the onnx branch January 22, 2025 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants