Upgrade pulldown-cmark to 0.10.3 #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdarkhan
force-pushed
the
pulldown-upgrade
branch
from
44d639f to
9b8b1d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
==========================================
- Coverage 90.43% 90.27% -0.16%
==========================================
Files 12 12
Lines 3010 3034 +24
Branches 3010 3034 +24
==========================================
+ Hits 2722 2739 +17
Misses 207 207
- Partials 81 88 +7 ☔ View full report in Codecov by Sentry. |
mgeisler
reviewed
Apr 16, 2024
kdarkhan
force-pushed
the
pulldown-upgrade
branch
from
9b8b1d7 to
90f54e7
Compare
kdarkhan
changed the title
mgeisler
reviewed
May 15, 2024
i18n-helpers/src/normalize.rs
Outdated
Comment on lines
56
to
58
| dest_url: _, | ||
| title: _, | ||
| id: _ |
There was a problem hiding this comment.
I think this could be replaced with .. like you do below. It's of course not an important difference 😄
kdarkhan
force-pushed
the
pulldown-upgrade
branch
from
90f54e7 to
08d10a6
Compare
kdarkhan
force-pushed
the
pulldown-upgrade
branch
from
08d10a6 to
418eb86
Compare
klensy
added a commit
to klensy/mdbook-i18n-helpers
that referenced
this pull request
Jul 2, 2024
html feature was added in google#183, but looks unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
pulldown-cmark-to-cmarknow supportspulldown-cmark. This should allow us to upgrade both dependencies.Had to adjust TagEnd handling and change some types to fix the build failures.
Information on breaking changes in
pulldown-cmarkis available here. Not sure if I am missing anything. I hope that the tests we have are extensive enough to catch any issues.