Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "部首" (radical) to radical candidate descriptions #1165

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

tats-u
Copy link
Contributor

@tats-u tats-u commented Jan 21, 2025

Description

A clear and concise description of this pull request.

Add "部首" to radical kanji candidate descriptions

Issue IDs

Issue and/or discussion IDs related to this pull request.

Fixes #1120

Steps to test new behaviors (if any)

A clear and concise description about how to verify new behaviors (if any).

  • OS: Windows 11 (other OSes are also OK)
  • Steps:
    1. input confusing radical names (e.g. の & む & おのれ)
    2. Compose
    3. Confirm the description texts for radical kanjis are not confusing now by the fact that "部首" is added there

image
image
image

Additional context

Add any other context about the pull request here.

"部首漢字" is too long and I chose "部首", which is shorter.

@tats-u
Copy link
Contributor Author

tats-u commented Jan 21, 2025

Is "の(部首)" instead of "部首(の)" better?

@hiroyuki-komatsu
Copy link
Collaborator

I think "部首(の)" is fine.

@hiroyuki-komatsu hiroyuki-komatsu merged commit be17aff into google:master Jan 22, 2025
1 check passed
@hiroyuki-komatsu
Copy link
Collaborator

We have merged your PR.
Thank you for the contribution!

@tats-u tats-u deleted the annotate-radicals branch January 22, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Description on radical kanji "丿" is confusing with katakana "ノ"
2 participants