-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implementation of .NET packages.config extractor and fixes #357
base: main
Are you sure you want to change the base?
Implementation of .NET packages.config extractor and fixes #357
Conversation
extractor/filesystem/language/dotnet/packagesconfig/testdata/valid
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Usually each result type of plugins has their own metadata struct. This is used in some use cases of Scalibr to distinguish result types
So you either add a metadata proto for .net. Then you need to update proto.go and scanresult proto. This is used in some programs to differentiate different result types. It's also recommended to have all necessary information in metadata for matching.
Or you don't, then that change is not required.
We chose not to introduce a new metadata structure for the .NET extractor because the existing implementation (see .NET |
extractor/filesystem/language/dotnet/packagesconfig/testdata/invalid
Outdated
Show resolved
Hide resolved
I didn't realize you were working on fixing the tests so I've submitted a commit to fix it in #382 |
Should work now |
Pull request for the .NET packages.config extractor.
Implemented:
Extractor implementation for package.config;
Unit test implementation for extractor:
Integration of the extractor in the main tool;
Fixes from the .NET PR #355.