Implementation of haskell stack extractor. #367
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikvarga
reviewed
Jan 10, 2025
| s := bufio.NewScanner(input.Reader) | ||
| pkgs := []*extractor.Inventory{} | ||
|
|
||
| for s.Scan() { |
There was a problem hiding this comment.
Check for scanner errors at the end, like in
erikvarga
reviewed
Jan 15, 2025
erikvarga
reviewed
Jan 15, 2025
erikvarga
approved these changes
Jan 16, 2025
|
looks good, can you do another sync to fix the merge conflicts? |
erikvarga
approved these changes
Jan 16, 2025
|
Same as for the Cabal PR, we'll need one more sync |
erikvarga
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for the haskell stack extractor.
Implemented: