-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(yarnlock): trim the trialing :
in the header
#406
Conversation
@G-Rath not sure if you have |
@cuixq could you provide more details on how you produced this lockfile? afaik this is invalid |
so only having the package name in the header is not allowed? we have a
and osv-scalibr extracts the package name as |
afaik there's no official specification for any version of So ideally it'd be good if you could come up with a reproduction for that lockfile - happy to take this "offline" if that'd be easier (I assume you've not shared more info as its a lockfile in a private codebase). |
Indeed, this is from a real case in a private codebase. |
Considering this change does not cause any trouble with the existing fixtures, it may be fine to merge it anyway. |
(to be clear, I'm not super against landing this, I'd just really like to try and figure out how it's generated in case there are other things we need to change 🙂) |
Understandable. Considering my limited knowledge about |
Without trimming the trialing
:
in the header, if the header is just the name, the name will be parsed wrongly with:
in it.