refactor: explicitly ignore errors that we don't need to handle #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuixq
approved these changes
Feb 18, 2025
vpasdf
reviewed
Feb 19, 2025
| @@ -544,7 +544,7 @@ func (i *ScanInput) GetRealPath() (string, error) { | |||
| return "", err | |||
| } | |||
| defer f.Close() | |||
| io.Copy(f, i.Reader) | |||
| _, _ = io.Copy(f, i.Reader) | |||
There was a problem hiding this comment.
I think this error should not be ignored
vpasdf
reviewed
Feb 19, 2025
| @@ -127,7 +127,7 @@ func readDir(fsys scalibrfs.FS, name string) (*dirIterator, error) { | |||
| if !ok { | |||
| // Fallback if ReadDirFile is not implemented: Use fs.DirFS's ReadDir(). | |||
| // (Uses more memory since it reads all subdirs at once.) | |||
| file.Close() | |||
| _ = file.Close() | |||
There was a problem hiding this comment.
This should not be ignored.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables the
errchecklinter which enforces errors be either handled or explicitly ignored to make it clear that the error handling has been thought about rather than mistakenly forgotten.Relates to #274